[ 
https://issues.apache.org/jira/browse/KYLIN-4855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258022#comment-17258022
 ] 

ASF GitHub Bot commented on KYLIN-4855:
---------------------------------------

wolfboys opened a new pull request #1536:
URL: https://github.com/apache/kylin/pull/1536


   ## Proposed changes
   
   After executed "system-cube.sh cron", the system cube will be added to the 
crontab, but the cube name is wrong, and it does not match the actual 
situation. After testing, it is found that the system-cube is
   There is a bug in the handling of kylin metrics prefix
   
   In system-cube.sh, the prefix is "KYLIN". The logic is wrong. You should get 
"kylin.metrics.prefix" from kylin.properties. If this item is set, take the 
value set by the user, if not set, go to the default value. "KYLIN"
   
   In bin/build-incremental-cube.sh The username and password default value 
ADMIN:KYLIN, if the password has been changed, it will not work
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have create an issue on [Kylin's 
jira](https://issues.apache.org/jira/browse/KYLIN-4855), and have described the 
bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like 
"KYLIN-0000 Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If this change need a document change, I will prepare another pr 
against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
user@kylin or dev@kylin by explaining why you chose the solution you did and 
what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> kylin metrics prefix bug in system-cube.sh
> ------------------------------------------
>
>                 Key: KYLIN-4855
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4855
>             Project: Kylin
>          Issue Type: Bug
>          Components: Environment 
>    Affects Versions: v2.6.0
>         Environment: 2.6.0+
>            Reporter: huajiewang
>            Priority: Minor
>              Labels: easyfix
>             Fix For: Future
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> After executed "system-cube.sh cron", the system cube will be added to the 
> crontab, but the cube name is wrong, and it does not match the actual 
> situation. After testing, it is found that the system-cube is
> There is a bug in the handling of kylin metrics prefix
> In the system-cube.sh script, the prefix is "KYLIN". The logic is wrong. You 
> should get "kylin.metrics.prefix" from kylin.properties. If this item is set, 
> take the value set by the user, if not set, go to the default value. "KYLIN"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to