[ 
https://issues.apache.org/jira/browse/KYLIN-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263104#comment-17263104
 ] 

ASF GitHub Bot commented on KYLIN-4857:
---------------------------------------

zzcclp commented on a change in pull request #1538:
URL: https://github.com/apache/kylin/pull/1538#discussion_r555540592



##########
File path: 
core-metrics/src/main/java/org/apache/kylin/metrics/property/QuerySparkStageEnum.java
##########
@@ -0,0 +1,52 @@
+package org.apache.kylin.metrics.property;

Review comment:
       Add license header




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Refactor system cube for kylin4
> -------------------------------
>
>                 Key: KYLIN-4857
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4857
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: v4.0.0-alpha
>            Reporter: Yaqian Zhang
>            Assignee: Yaqian Zhang
>            Priority: Minor
>             Fix For: v4.0.0-beta
>
>
> With the change of query engine and storage, the query related metrics 
> collected by system cube in kylin3 are no longer applicable to kylin4, so it 
> needs to be refactor to adapt to the spark query engine in kylin4.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to