chenjie-sau commented on a change in pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#discussion_r587421975
##########
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -933,7 +933,7 @@ public String getHiveDependencyFilterList() {
+ "[^,]*hive-metastore[^,]*?\\.jar" + "|" +
"[^,]*hive-hcatalog-core[^,]*?\\.jar");
}
- public boolean isMailEnabled() {
+ public boolean isNotifyEnabled() {
Review comment:
notification is a noun, notify is a verb， I think it’s better to use
verbs here， What do you think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
