[jira] [Commented] (KYLIN-4921) stream config lost when create table with same table_name in diff project.

Mon, 08 Mar 2021 19:26:05 -0800 


    [ 
https://issues.apache.org/jira/browse/KYLIN-4921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297811#comment-17297811
 ] 

ASF GitHub Bot commented on KYLIN-4921:
---------------------------------------

coveralls commented on pull request #1604:
URL: https://github.com/apache/kylin/pull/1604#issuecomment-793321612


   ## Pull Request Test Coverage Report for [Build 
6949](https://coveralls.io/builds/37763391)
   
   * **4** of **85**   **(4.71%)**  changed or added relevant lines in **12** 
files are covered.
   * **13** unchanged lines in **6** files lost coverage.
   * Overall coverage decreased (**-0.01%**) to **27.942%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | 
[server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java](https://coveralls.io/builds/37763391/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FTableController.java#L162)
 | 0 | 1 | 0.0%
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/ProjectService.java](https://coveralls.io/builds/37763391/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FProjectService.java#L155)
 | 0 | 1 | 0.0%
   | 
[stream-receiver/src/main/java/org/apache/kylin/stream/server/StreamingServer.java](https://coveralls.io/builds/37763391/source?filename=stream-receiver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fserver%2FStreamingServer.java#L706)
 | 0 | 1 | 0.0%
   | 
[stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/KafkaBatchSourceAdaptor.java](https://coveralls.io/builds/37763391/source?filename=stream-source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fsource%2Fkafka%2FKafkaBatchSourceAdaptor.java#L37)
 | 0 | 1 | 0.0%
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/TableService.java](https://coveralls.io/builds/37763391/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FTableService.java#L323)
 | 0 | 2 | 0.0%
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/StreamingV2Service.java](https://coveralls.io/builds/37763391/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FStreamingV2Service.java#L110)
 | 0 | 4 | 0.0%
   | 
[stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/KafkaSource.java](https://coveralls.io/builds/37763391/source?filename=stream-source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fsource%2Fkafka%2FKafkaSource.java#L79)
 | 0 | 5 | 0.0%
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/source/StreamingSourceConfig.java](https://coveralls.io/builds/37763391/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fsource%2FStreamingSourceConfig.java#L63)
 | 0 | 8 | 0.0%
   | 
[tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java](https://coveralls.io/builds/37763391/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FCubeMigrationCLI.java#L346)
 | 0 | 9 | 0.0%
   | 
[server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/37763391/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L113)
 | 0 | 14 | 0.0%
   <!-- | **Total:** | **4** | **85** | **4.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | 
[server-base/src/main/java/org/apache/kylin/rest/controller/StreamingV2Controller.java](https://coveralls.io/builds/37763391/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FStreamingV2Controller.java#L321)
 | 1 | 0% |
   | 
[server-base/src/main/java/org/apache/kylin/rest/service/TableService.java](https://coveralls.io/builds/37763391/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FTableService.java#L326)
 | 1 | 10.89% |
   | 
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/37763391/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42)
 | 1 | 81.58% |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/source/StreamingSourceConfigManager.java](https://coveralls.io/builds/37763391/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fsource%2FStreamingSourceConfigManager.java#L87)
 | 2 | 0% |
   | 
[tool/src/main/java/org/apache/kylin/tool/CubeMigrationCLI.java](https://coveralls.io/builds/37763391/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FCubeMigrationCLI.java#L366)
 | 3 | 0% |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/37763391/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
 | 5 | 77.81% |
   <!-- | **Total:** | **13** |  | -->
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/37763391/badge)](https://coveralls.io/builds/37763391)
 |
   | :-- | --: |
   | Change from base [Build 6948](https://coveralls.io/builds/37745441): |  
-0.01% |
   | Covered Lines: | 26255 |
   | Relevant Lines: | 93961 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> stream config lost when create table with same table_name in diff project.
> --------------------------------------------------------------------------
>
>                 Key: KYLIN-4921
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4921
>             Project: Kylin
>          Issue Type: Bug
>          Components: Real-time Streaming
>            Reporter: Kun Liu
>            Assignee: Kun Liu
>            Priority: Major
>
> In project A, I have created a stream table test_table.
> When I create the table test_table in project B, the table can't be created, 
> but the source config of table in project A lost. 
>  
> The reason: 
> In the `saveStreamingConfig` function, if creating table failed, the config 
> will be dropped in finally phase.
>  
>  
> By design: 
> In order to identity one stream table `StreamingSourceConfig` in the 
> metastore, kylin use the key
> `ResourceStore.STREAMING_V2_RESOURCE_ROOT + "/" + name + ".json"` as the 
> identifier.
> But this design can't work in multi-project.
> [~hit_lacus] PTAL
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to