[ 
https://issues.apache.org/jira/browse/KYLIN-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299220#comment-17299220
 ] 

ASF GitHub Bot commented on KYLIN-4929:
---------------------------------------

coveralls edited a comment on pull request #1605:
URL: https://github.com/apache/kylin/pull/1605#issuecomment-794803012


   ## Pull Request Test Coverage Report for [Build 
6957](https://coveralls.io/builds/37836371)
   
   * **0** of **3**   **(0.0%)**  changed or added relevant lines in **2** 
files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.002%**) to **27.957%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | 
[server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetrics2Facade.java](https://coveralls.io/builds/37836371/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmetrics%2FQueryMetrics2Facade.java#L62)
 | 0 | 1 | 0.0%
   | 
[server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetricsFacade.java](https://coveralls.io/builds/37836371/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fmetrics%2FQueryMetricsFacade.java#L88)
 | 0 | 2 | 0.0%
   <!-- | **Total:** | **0** | **3** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | 
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/37836371/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146)
 | 1 | 56.82% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/37836371/badge)](https://coveralls.io/builds/37836371)
 |
   | :-- | --: |
   | Change from base [Build 6948](https://coveralls.io/builds/37745441): |  
0.002% |
   | Covered Lines: | 26259 |
   | Relevant Lines: | 93925 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> skip metrics update for simple queries to avoid NPE warnings
> ------------------------------------------------------------
>
>                 Key: KYLIN-4929
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4929
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: Congling Xia
>            Assignee: Congling Xia
>            Priority: Minor
>             Fix For: v3.1.2
>
>
> Users may use simple queries like 'select 1' to check the availability of 
> kylin service. No realization is needed for such queries. Metric system will 
> raise NullPointerException when trying to get the name of the realization.
> It does not cause the query to fail, but prints a lot of annoying warning 
> logs with stack-traces.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to