zhengshengjun commented on a change in pull request #1611:
URL: https://github.com/apache/kylin/pull/1611#discussion_r596072430
##########
File path: build/bin/kylin.sh
##########
@@ -143,9 +143,9 @@ function retrieveDependency() {
# compose hadoop_dependencies
hadoop_dependencies=${hadoop_dependencies}:`hadoop classpath`
-# if [ -n "${hbase_dependency}" ]; then
-# hadoop_dependencies=${hadoop_dependencies}:${hbase_dependency}
-# fi
+ if [ -n "${hbase_dependency}" ]; then
Review comment:
Agreed ! It breaks the long term goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
