[
https://issues.apache.org/jira/browse/KYLIN-4933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304049#comment-17304049
]
ASF GitHub Bot commented on KYLIN-4933:
---------------------------------------
codecov-io commented on pull request #1613:
URL: https://github.com/apache/kylin/pull/1613#issuecomment-801833776
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1613?src=pr&el=h1) Report
> Merging
[#1613](https://codecov.io/gh/apache/kylin/pull/1613?src=pr&el=desc) (2cc1ef1)
into
[master](https://codecov.io/gh/apache/kylin/commit/02500818d85955b1125340eaa19ab88a634a5181?el=desc)
(0250081) will **decrease** coverage by `0.02%`.
> The diff coverage is `12.59%`.
[](https://codecov.io/gh/apache/kylin/pull/1613?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1613 +/- ##
============================================
- Coverage 25.42% 25.40% -0.03%
+ Complexity 6765 6762 -3
============================================
Files 1508 1508
Lines 93918 93976 +58
Branches 13158 13169 +11
============================================
- Hits 23877 23871 -6
- Misses 67662 67724 +62
- Partials 2379 2381 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/1613?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
|---|---|---|---|
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `12.42% <0.00%> (-0.05%)` | `51.00 <0.00> (ø)` | |
|
[...che/kylin/storage/gtrecord/CubeTupleConverter.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0N1YmVUdXBsZUNvbnZlcnRlci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...e/kylin/rest/controller/StreamingV2Controller.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TdHJlYW1pbmdWMkNvbnRyb2xsZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[.../apache/kylin/rest/controller/TableController.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9UYWJsZUNvbnRyb2xsZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...apache/kylin/rest/metrics/QueryMetrics2Facade.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvbWV0cmljcy9RdWVyeU1ldHJpY3MyRmFjYWRlLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[.../apache/kylin/rest/metrics/QueryMetricsFacade.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvbWV0cmljcy9RdWVyeU1ldHJpY3NGYWNhZGUuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...va/org/apache/kylin/rest/service/CacheService.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DYWNoZVNlcnZpY2UuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[.../org/apache/kylin/rest/service/ProjectService.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9Qcm9qZWN0U2VydmljZS5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[.../apache/kylin/rest/service/StreamingV2Service.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9TdHJlYW1pbmdWMlNlcnZpY2UuamF2YQ==)
| `8.96% <0.00%> (ø)` | `9.00 <0.00> (ø)` | |
|
[...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==)
| `10.31% <0.00%> (-0.03%)` | `9.00 <0.00> (ø)` | |
| ... and [18
more](https://codecov.io/gh/apache/kylin/pull/1613/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1613?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1613?src=pr&el=footer). Last
update
[49d7b9b...2cc1ef1](https://codecov.io/gh/apache/kylin/pull/1613?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support set cache strength for dict cache
> -----------------------------------------
>
> Key: KYLIN-4933
> URL: https://issues.apache.org/jira/browse/KYLIN-4933
> Project: Kylin
> Issue Type: Improvement
> Affects Versions: v3.1.1
> Reporter: ShengJun Zheng
> Priority: Major
>
> Kylin uses guava LoadingCache(LUR Cache) to cache dictionary with
> soft(SoftReference) cache strength , it will be collected due to JVM GC.
> In cases of queries over dict-encoded-dimension cubes, we would always
> prefer to cache dimension dictionary in LUR cache to avoid reloading dict
> from HBase/HDFS, which will causes unstable query performance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
