[ 
https://issues.apache.org/jira/browse/KYLIN-4935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304067#comment-17304067
 ] 

ASF GitHub Bot commented on KYLIN-4935:
---------------------------------------

zhangayqian edited a comment on pull request #1612:
URL: https://github.com/apache/kylin/pull/1612#issuecomment-801846308


   This patch looks good to me and test passed.
   - Some job info will be lost before this patch
   <img width="642" alt="jobInfo" 
src="https://user-images.githubusercontent.com/31064237/111617302-e60d6a00-881d-11eb-8b1f-454bd2645b0f.png";>
   
   - Job info can be displayed normally after fix
   <img width="583" alt="image" 
src="https://user-images.githubusercontent.com/31064237/111617695-67fd9300-881e-11eb-9a5c-829e7020c522.png";>
   
   The master branch did not find this bug. But this patch still can be 
cherry-pick to the master branch to prevent this bug.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Existing JobOutput's extend info will be lost when it is updated
> ----------------------------------------------------------------
>
>                 Key: KYLIN-4935
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4935
>             Project: Kylin
>          Issue Type: Bug
>          Components: Job Engine
>    Affects Versions: v4.0.0-beta
>            Reporter: ShengJun Zheng
>            Priority: Minor
>             Fix For: v4.0.0-GA
>
>         Attachments: image-2021-03-17-10-32-36-978.png
>
>
> Existing JobOutput's extend info will be lost when it is updated. The update 
> will replace the previous info(map) with new one, but the new one doesn't 
> contain all old informations.
> It can cause job execute info incorrect, like duration in web ui:
> !image-2021-03-17-10-32-36-978.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to