hit-lacus commented on a change in pull request #1615:
URL: https://github.com/apache/kylin/pull/1615#discussion_r600422370
##########
File path: core-cube/src/main/java/org/apache/kylin/cube/CubeDescManager.java
##########
@@ -256,6 +256,18 @@ public CubeDesc updateCubeDesc(CubeDesc desc) throws
IOException {
}
}
+ public CubeDesc updateCubeDescToBeGlobal(CubeDesc desc, String
lookupTable, boolean global) throws IOException {
Review comment:
The name of this method is misleading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
