hit-lacus commented on a change in pull request #1618:
URL: https://github.com/apache/kylin/pull/1618#discussion_r603278306
##########
File path:
kylin-spark-project/kylin-spark-metadata/src/main/scala/org/apache/kylin/engine/spark/metadata/MetadataConverter.scala
##########
@@ -115,6 +117,21 @@ object MetadataConverter {
dimensionIndex
}
+ def extractAllRowkeyColumnDesc(cubeInstance: CubeInstance):
java.util.LinkedHashMap[Integer, ColumnDesc] = {
Review comment:
There are some lines of code are duplicated in method
`extractAllRowkeyColumnDesc` and ethod `extractAllColumnDesc`. Maybe we can
improve the code smell by merge them into one method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
