[
https://issues.apache.org/jira/browse/KYLIN-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310698#comment-17310698
]
ASF GitHub Bot commented on KYLIN-4918:
---------------------------------------
zzcclp commented on a change in pull request #1603:
URL: https://github.com/apache/kylin/pull/1603#discussion_r603356675
##########
File path:
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala
##########
@@ -78,6 +77,8 @@ class FilePruner(cubeInstance: CubeInstance,
val options: Map[String, String])
extends FileIndex with ResetShufflePartition with Logging {
+ val MAX_SHARDING_SIZE_PER_TASK: Long =
cubeInstance.getConfig.getMaxShardingSizeMBPerTask * 1024 * 1024
Review comment:
this line will exceed 100 chars, please change to:
```
val MAX_SHARDING_SIZE_PER_TASK: Long =
cubeInstance.getConfig.getMaxShardingSizeMBPerTask * 1024 * 1024
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Cube Level configuration in FilePruner
> ----------------------------------------------
>
> Key: KYLIN-4918
> URL: https://issues.apache.org/jira/browse/KYLIN-4918
> Project: Kylin
> Issue Type: Improvement
> Components: Query Engine
> Reporter: ShengJun Zheng
> Assignee: ShengJun Zheng
> Priority: Minor
>
> FilePruner will generate shard spec to optimize join performance, but related
> configuration is not supported at cube level
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
