dixingxing0 opened a new pull request #1622: URL: https://github.com/apache/kylin/pull/1622
## Proposed changes org.apache.kylin.stream.core.storage.columnar.ColumnarMemoryStorePersister#persist will catch exception and just log it, this behavior will cause critical problem, like our case: there is no space left on device, `persist` method failed for many times, we lost several hours of data. ## Types of changes What types of changes does your code introduce to Kylin? _Put an `x` in the boxes that apply_ - [x ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation Update (if none of the other choices apply) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail - [ x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source" - [ x] Compiling and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If this change need a document change, I will prepare another pr against the `document` branch - [ ] Any dependent changes have been merged ## Further comments Here is our solution which already tested: 1.Throw IllegalStorageException while we cannot do the persist 2.Then stop the consumer thread 3.Add `consumer_thread_alive` in ConsumerStats for monitoring 4.Also fix an another issue which will cause wrong result after restore from checkpoint -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
