[
https://issues.apache.org/jira/browse/KYLIN-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317840#comment-17317840
]
ASF GitHub Bot commented on KYLIN-4964:
---------------------------------------
coveralls edited a comment on pull request #1622:
URL: https://github.com/apache/kylin/pull/1622#issuecomment-815868699
## Pull Request Test Coverage Report for [Build
7042](https://coveralls.io/builds/38673768)
* **0** of **14** **(0.0%)** changed or added relevant lines in **4**
files are covered.
* **9** unchanged lines in **5** files lost coverage.
* Overall coverage decreased (**-0.003%**) to **28.088%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/model/stats/ConsumerStats.java](https://coveralls.io/builds/38673768/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fmodel%2Fstats%2FConsumerStats.java#L110)
| 0 | 3 | 0.0%
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarMemoryStorePersister.java](https://coveralls.io/builds/38673768/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarMemoryStorePersister.java#L114)
| 0 | 3 | 0.0%
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarSegmentStore.java](https://coveralls.io/builds/38673768/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarSegmentStore.java#L316)
| 0 | 3 | 0.0%
|
[stream-core/src/main/java/org/apache/kylin/stream/core/consumer/StreamingConsumerChannel.java](https://coveralls.io/builds/38673768/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fconsumer%2FStreamingConsumerChannel.java#L119)
| 0 | 5 | 0.0%
<!-- | **Total:** | **0** | **14** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/consumer/StreamingConsumerChannel.java](https://coveralls.io/builds/38673768/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fconsumer%2FStreamingConsumerChannel.java#L310)
| 1 | 0% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarSegmentStore.java](https://coveralls.io/builds/38673768/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarSegmentStore.java#L324)
| 1 | 64.14% |
|
[stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/GeneralColumnDataReader.java](https://coveralls.io/builds/38673768/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FGeneralColumnDataReader.java#L43)
| 1 | 92.11% |
|
[tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/38673768/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L44)
| 1 | 81.58% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/38673768/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
| 5 | 77.81% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/38673768)
|
| :-- | --: |
| Change from base [Build 7032](https://coveralls.io/builds/38574273): |
-0.003% |
| Covered Lines: | 26713 |
| Relevant Lines: | 95104 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Receiver consumer thread should be stoped while encounting unrecoverable error
> ------------------------------------------------------------------------------
>
> Key: KYLIN-4964
> URL: https://issues.apache.org/jira/browse/KYLIN-4964
> Project: Kylin
> Issue Type: Bug
> Components: Real-time Streaming
> Affects Versions: v3.1.1
> Reporter: Xingxing Di
> Assignee: Xingxing Di
> Priority: Major
>
> org.apache.kylin.stream.core.storage.columnar.ColumnarMemoryStorePersister#persist
> will catch exception and just log it, this behavior will cause critical
> problem, like our case: there is no space left on device, `persist` method
> failed for many times, we lost several hours of data.
> Here is our solution which already tested:
> # Throw IllegalStorageException while we cannot do the persist
> # Then stop the consumer thread
> # Add `consumer_thread_alive` in ConsumerStats for monitoring
> # Also fix an another issue which will cause wrong result after restore from
> checkpoint
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
