[
https://issues.apache.org/jira/browse/KYLIN-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318788#comment-17318788
]
ASF GitHub Bot commented on KYLIN-4967:
---------------------------------------
zzcclp opened a new pull request #1627:
URL: https://github.com/apache/kylin/pull/1627
## Proposed changes
With spark 2.X, when set 'spark.sql.adaptive.enabled' to true, it will
impact the actually partition count when doing repartition with spark, which
will lead to the wrong results for global dict and repartition by shardby
column.
For example, after writing a cuboid data, kylin will repartition the cuboid
data with 3 partition if need, but if 'spark.sql.adaptive.enabled' is true,
spark will optimize the partition num to 1, which leads to wrong.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look for
before merging your code._
- [ ] I have create an issue on [Kylin's
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the
bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like
"KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature
works
- [ ] If this change need a document change, I will prepare another pr
against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at
user@kylin or dev@kylin by explaining why you chose the solution you did and
what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Forbid to set 'spark.sql.adaptive.enabled' to true when building cube with
> Spark 2.X
> ------------------------------------------------------------------------------------
>
> Key: KYLIN-4967
> URL: https://issues.apache.org/jira/browse/KYLIN-4967
> Project: Kylin
> Issue Type: Bug
> Reporter: Zhichao Zhang
> Assignee: Zhichao Zhang
> Priority: Minor
>
> With spark 2.X, when set 'spark.sql.adaptive.enabled' to true, it will impact
> the actually partition count when doing repartition with spark, which will
> lead to the wrong results for global dict and repartition by shardby column.
> For example, after writing a cuboid data, kylin will repartition the cuboid
> data with 3 partition if need, but if 'spark.sql.adaptive.enabled' is true,
> spark will optimize the partition num to 1, which leads to wrong.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
