[
https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335109#comment-17335109
]
ASF GitHub Bot commented on KYLIN-4780:
---------------------------------------
hit-lacus edited a comment on pull request #1596:
URL: https://github.com/apache/kylin/pull/1596#issuecomment-828891154
I wish this patch could be well designed for extensible purpose, and a
**notification framework** should be developed from my side.
So, if other guys want to add support for We-chat or Slack, it should be
very easy because he/her should only provided some implementation depend on
this **notification framework** .
I found that you provided a simple framework with some base classes :
`NotifyServiceBase`, `NotificationContext`, `NotificationTransmitter`. I am not
really sure if it is enough extensible. What do you think ?
Besides, the
[alibaba-dingtalk-service-sdk](https://repo1.maven.org/maven2/com/aliyun/alibaba-dingtalk-service-sdk/1.0.1/])
is not maintained by apache software foundation or and other open source
organization, and the source code didn't have a proper asf-compatible license
at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor AbstractExecutable to extract the notification relevant business
> logic into a single component
> -------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4780
> URL: https://issues.apache.org/jira/browse/KYLIN-4780
> Project: Kylin
> Issue Type: Improvement
> Components: Integration
> Reporter: vinoyang
> Assignee: chenjie
> Priority: Major
>
> Currently, Kylin supports mail service to know the change around the cube.
> However, there are some issues about the design, e.g.
> * AbstractExecutable contains an implementation of the mechanism of a
> notification listener, but only support mail service, it does not belong
> there;
> * The current implementation is hard to scale to other notification e.g.
> Ding Talk(which is a popular production supports by Alibaba)
> I propose to refactor the current implementation to extract the notification
> logic and redesign a new common notification/listener
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
