[
https://issues.apache.org/jira/browse/KYLIN-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351565#comment-17351565
]
ASF GitHub Bot commented on KYLIN-4966:
---------------------------------------
hit-lacus commented on a change in pull request #1636:
URL: https://github.com/apache/kylin/pull/1636#discussion_r639446171
##########
File path:
kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/FilterRecommendCuboidJob.java
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kylin.engine.spark.job;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileUtil;
+import org.apache.hadoop.fs.Path;
+import org.apache.kylin.common.util.HadoopUtil;
+import org.apache.kylin.cube.CubeInstance;
+import org.apache.kylin.cube.CubeManager;
+import org.apache.kylin.cube.CubeSegment;
+import org.apache.kylin.cube.cuboid.CuboidModeEnum;
+import org.apache.kylin.engine.mr.steps.CubingExecutableUtil;
+import org.apache.kylin.engine.spark.application.SparkApplication;
+import org.apache.kylin.engine.spark.metadata.cube.PathManager;
+import org.apache.kylin.shaded.com.google.common.base.Preconditions;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.Set;
+
+public class FilterRecommendCuboidJob extends SparkApplication {
+ protected static final Logger logger =
LoggerFactory.getLogger(FilterRecommendCuboidJob.class);
+
+ private long baseCuboid;
+ private Set<Long> recommendCuboids;
+
+ private FileSystem fs = HadoopUtil.getWorkingFileSystem();
+ private Configuration conf = HadoopUtil.getCurrentConfiguration();
+
+ public FilterRecommendCuboidJob() {
+
+ }
+
+ public String getCuboidRootPath(CubeSegment segment) {
+ return
PathManager.getSegmentParquetStoragePath(segment.getCubeInstance(),
segment.getName(),
+ segment.getStorageLocationIdentifier());
+ }
+
+ @Override
+ protected void doExecute() throws Exception {
+ infos.clearReusedCuboids();
+ final CubeManager mgr = CubeManager.getInstance(config);
+ final CubeInstance cube =
mgr.getCube(CubingExecutableUtil.getCubeName(this.getParams())).latestCopyForWrite();
+ final CubeSegment optimizeSegment =
cube.getSegmentById(CubingExecutableUtil.getSegmentId(this.getParams()));
+
+ CubeSegment oldSegment =
optimizeSegment.getCubeInstance().getOriginalSegmentToOptimize(optimizeSegment);
+ Preconditions.checkNotNull(oldSegment,
+ "cannot find the original segment to be optimized by " +
optimizeSegment);
+
+
infos.recordReusedCuboids(Collections.singleton(cube.getCuboidsByMode(CuboidModeEnum.RECOMMEND_EXISTING)));
+
+ baseCuboid = cube.getCuboidScheduler().getBaseCuboidId();
+ recommendCuboids = cube.getCuboidsRecommend();
+
+ Preconditions.checkNotNull(recommendCuboids, "The recommend cuboid map
could not be null");
Review comment:
`map` or `set`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refresh the existing segment according to the new cuboid list in kylin4
> -----------------------------------------------------------------------
>
> Key: KYLIN-4966
> URL: https://issues.apache.org/jira/browse/KYLIN-4966
> Project: Kylin
> Issue Type: New Feature
> Components: Job Engine
> Affects Versions: v4.0.0-beta
> Reporter: Yaqian Zhang
> Assignee: Yaqian Zhang
> Priority: Minor
> Fix For: v4.0.0-GA
>
>
> When the user wants to update the cuboid list of a cube, the existing segment
> needs to be refreshed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
