zhengshengjun commented on a change in pull request #1631:
URL: https://github.com/apache/kylin/pull/1631#discussion_r642321082
##########
File path:
engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkCubingByLayer.java
##########
@@ -330,15 +409,12 @@ public EncodeBaseCuboid(String cubeName, String
segmentId, String metaurl, Seria
long baseCuboidId =
Cuboid.getBaseCuboidId(cubeDesc);
Cuboid baseCuboid =
Cuboid.findForMandatory(cubeDesc, baseCuboidId);
String splitKey =
String.valueOf(TaskContext.getPartitionId());
- try {
Review comment:
The original implementation will catch exception and print StackTrace in
stand output, the spark job will continue to run. Maybe it's not an expected
behavior, should we remove try catch and fail fast ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
