[ 
https://issues.apache.org/jira/browse/KYLIN-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363406#comment-17363406
 ] 

ASF GitHub Bot commented on KYLIN-5011:
---------------------------------------

codecov-commenter commented on pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#issuecomment-861217072


   # 
[Codecov](https://codecov.io/gh/apache/kylin/pull/1662?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > :exclamation: No coverage uploaded for pull request base 
(`kylin-on-parquet-v2@c943745`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head c9afca4 differs from pull request most recent 
head 826a722. Consider uploading reports for the commit 826a722 to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/1662/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/kylin/pull/1662?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@                  Coverage Diff                   @@
   ##             kylin-on-parquet-v2    #1662   +/-   ##
   ======================================================
     Coverage                       ?   23.97%           
     Complexity                     ?     4650           
   ======================================================
     Files                          ?     1158           
     Lines                          ?    66491           
     Branches                       ?     9743           
   ======================================================
     Hits                           ?    15941           
     Misses                         ?    48870           
     Partials                       ?     1680           
   ```
   
   
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/1662?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/1662?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[c943745...826a722](https://codecov.io/gh/apache/kylin/pull/1662?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Detect and scatter skewed data in dict encoding step
> ----------------------------------------------------
>
>                 Key: KYLIN-5011
>                 URL: https://issues.apache.org/jira/browse/KYLIN-5011
>             Project: Kylin
>          Issue Type: New Feature
>          Components: Job Engine
>    Affects Versions: v4.0.0-beta
>            Reporter: ShengJun Zheng
>            Assignee: ShengJun Zheng
>            Priority: Major
>             Fix For: v4.0.0
>
>         Attachments: image-2021-06-15-10-54-19-419.png
>
>
> In KYLIN4, dictionaries are hashed into several buckets, column data are 
> repartitioned to the same partition size as bucket size. Then, each encoding 
> task is able to load a piece of  dictionary bucket to accelerate the encoding 
> step. 
> Recently we are troubled by this improvement when data skew happens. In some 
> of our cases, the repartition step during encoding is even impossible to 
> finish . Whereas this works fine in KYLIN3, for each Spark task will load all 
> dictionary of a column and encode column values to int values. There is no 
> need to do repartition step in KYLIN3.
> We solve this by:
>  # sample from source data and detect skewed data
>  # build skewed data's dictionary
>  # customize an repartition function to scatter skewed data to random 
> partitions
>  # do encoding with both skewed dictionary and dictionary loaded within each 
> partition
> After this improvement, some of our cube's build time reduced from 190min to 
> 30min
> !image-2021-06-15-10-54-19-419.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to