zzcclp commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655075865
##########
File path:
kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##########
@@ -382,6 +387,8 @@ protected String generateSparkCmd(KylinConfig config,
String hadoopConf, String
if (StringUtils.isNotBlank(sparkUploadFiles)) {
sb.append("--files ").append(sparkUploadFiles).append(" ");
}
+ sb.append("--principal
").append(config.getKerberosPrincipal()).append(" ");
+ sb.append("--keytab ").append(config.getKerberosKeytabPath()).append("
");
Review comment:
why it needs these two lines directly ? please check the code in the
method 'replaceSparkNodeJavaOpsConfIfNeeded', it will set the parameters about
kerberos according to 'config.isKerberosEnabled()'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
