[
https://issues.apache.org/jira/browse/KYLIN-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374464#comment-17374464
]
ASF GitHub Bot commented on KYLIN-5023:
---------------------------------------
zhengshengjun commented on a change in pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#discussion_r663609349
##########
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/spark/deploy/StandaloneAppClient.scala
##########
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.deploy
+
+import org.apache.kylin.common.KylinConfig
+import org.apache.kylin.engine.spark.utils.RestService
+import org.apache.spark.internal.Logging
+
+import java.io.IOException
+import scala.collection.mutable
+import scala.util.parsing.json.JSON._
+
+
+object StandaloneAppClient extends Logging {
+
+ private val JOB_STEP_PREFIX = "job_step_"
+
+ // appId -> (appName, state, starttime)
+ private val cachedKylinJobMap: mutable.Map[String, (String, String, Long)] =
new mutable.LinkedHashMap[String, (String, String, Long)]()
+
+ private var jobInfoUpdateTime = System.currentTimeMillis()
+ private val cacheTtl = 3600 * 1000 * 24 * 5
+ private val cacheMaxSize = 30000
+
+ // private val masterUrlHtml: String =
KylinConfig.getInstanceFromEnv.getSparkStandaloneMasterWebUI + "/app/?appId="
+ private val masterUrlJson: String =
KylinConfig.getInstanceFromEnv.getSparkStandaloneMasterWebUI + "/json"
+
+ private val restService: RestService = new RestService(10000, 10000)
+
+
+ /**
+ * @see org.apache.spark.deploy.master.ApplicationInfo
+ * @return Kylin's Build Job 's ApplicationInfo, update every 5 minutes
+ */
+ def getRunningJobs: mutable.Map[String, (String, String, Long)] =
cachedKylinJobMap.synchronized {
+ val currMills = System.currentTimeMillis
+ if (cachedKylinJobMap.isEmpty || currMills - jobInfoUpdateTime >= 10000) {
+ logDebug("Updating app status ...")
+ try {
+ val realResp = restService.getRequest(masterUrlJson)
+ parseApplicationState(realResp)
+ } catch {
+ case ioe: IOException => logError("Can not connect to standalone
master service.", ioe)
+ case e: Exception => logError("Error .", e)
+ }
+ jobInfoUpdateTime = currMills
+ }
+ cachedKylinJobMap
+ }
+
+ def getAppState(stepId: String): String = {
+ getRunningJobs
+
+ val doNothing: PartialFunction[(String, String, Long), (String, String,
Long)] = {
+ case x => x
+ }
+ val res: Iterable[(String, String, Long)] =
cachedKylinJobMap.values.filter(app =>
app._1.contains(stepId)).collect(doNothing)
+
+ res.size match {
+ case 0 => "SUBMITTED"
+ case 1 => res.head._2
+ case _ =>
+ // find the recent submitted application
+ res.maxBy(x => x._3)._2
+ }
+ }
+
+
+ def parseApplicationState(responseStr: String): Unit = {
+ val curr = System.currentTimeMillis()
+
+ var respJson = Map.empty[String, Any]
+ val tree = parseFull(responseStr)
+ respJson = tree match {
+ case Some(map: Map[String, Any]) => map
+ }
Review comment:
maybe simplify to:
val respJson = parseFull(responseStr).get.asInstanceOf[Map[String, Any]]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Support cluster deployMode for Spark App which master is standalone
> -------------------------------------------------------------------
>
> Key: KYLIN-5023
> URL: https://issues.apache.org/jira/browse/KYLIN-5023
> Project: Kylin
> Issue Type: Task
> Components: Spark Engine
> Affects Versions: v4.0.0-beta
> Reporter: Xiaoxiang Yu
> Assignee: Xiaoxiang Yu
> Priority: Major
> Fix For: v4.0.0
>
>
> Support cluster deployMode for Spark App which master is standalone
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
