[
https://issues.apache.org/jira/browse/KYLIN-5029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375776#comment-17375776
]
ASF GitHub Bot commented on KYLIN-5029:
---------------------------------------
xiacongling opened a new pull request #1683:
URL: https://github.com/apache/kylin/pull/1683
KYLIN-5029 set metrics refresh interval to a smaller value to make sure
tests always passed
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to ask.
We're here to help! This is simply a reminder of what we are going to look for
before merging your code._
- [x] I have create an issue on [Kylin's
jira](https://issues.apache.org/jira/browse/KYLIN), and have described the
bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like
"KYLIN-0000 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature
works
- [ ] If this change need a document change, I will prepare another pr
against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> metrics test may fail because the cache is not refreshed
> --------------------------------------------------------
>
> Key: KYLIN-5029
> URL: https://issues.apache.org/jira/browse/KYLIN-5029
> Project: Kylin
> Issue Type: Improvement
> Components: Tools, Build and Test
> Reporter: Congling Xia
> Assignee: Congling Xia
> Priority: Major
>
> Tests in _org.apache.kylin.rest.metrics.QueryMetricsTest_ may fail in current
> CI processes. There are some "Thread.sleep(..)" in the test code to wait for
> metrics cache being refreshed.
> After digging into the Hadoop metrics implementation, I find that the default
> refreshing interval is 10 seconds. So test thread should sleep for more than
> 10 seconds to may sure metrics are up-to-date. I checked the sleep intervals
> in the test code and they are not greater than 10000 (ms). That's why CI
> processes fail accidentally.
> It is better to configure metrics refreshing interval to a smaller value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
