[ 
https://issues.apache.org/jira/browse/KYLIN-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433591#comment-17433591
 ] 

ASF GitHub Bot commented on KYLIN-5069:
---------------------------------------

lgtm-com[bot] commented on pull request #1754:
URL: https://github.com/apache/kylin/pull/1754#issuecomment-950583015


   This pull request **fixes 1 alert** when merging 
5ca2dcaa2f4e39877cf21d73ea433d18312bebdb into 
df6dd4726a90fdabb4dc4e04daacbee8f206b782 - [view on 
LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-eb3b2a82c914e9b3d2dbc56cce00869b49f41058)
   
   **fixed alerts:**
   
   * 1 for Useless null check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Remove find-hive-dependency.sh in Kylin 4
> -----------------------------------------
>
>                 Key: KYLIN-5069
>                 URL: https://issues.apache.org/jira/browse/KYLIN-5069
>             Project: Kylin
>          Issue Type: Improvement
>    Affects Versions: v4.0.0
>            Reporter: Xiaoxiang Yu
>            Assignee: Yaqian Zhang
>            Priority: Major
>             Fix For: v4.0.1
>
>         Attachments: image-2021-08-30-16-10-46-712.png
>
>
> In kylin.sh, Kylin introduces a lot of jars into Kylin instance's class path, 
> via find-hive-dependency.sh and "hadoop classpath". So class conflict issues 
> happened often, and most of them are related with hive jars. I think it is 
> better to remove 'find-hive-dependency.sh' and use  SparkSession to fetch 
> Hive meta.
>  
> Following is part of script kylin.sh :
> {code:java}
> tomcat_classpath=${tomcat_root}/bin/bootstrap.jar:${tomcat_root}/bin/tomcat-juli.jar:${tomcat_root}/lib/*
>  export 
> KYLIN_TOMCAT_CLASSPATH=${tomcat_classpath}:${KYLIN_HOME}/conf:${KYLIN_HOME}/lib/*:${KYLIN_HOME}/ext/*:${hadoop_dependencies}:${flink_dependency}
> {code}
>  
> Some exception looks like this:
> !image-2021-08-30-16-10-46-712.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to