[
https://issues.apache.org/jira/browse/KYLIN-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442631#comment-17442631
]
ASF GitHub Bot commented on KYLIN-5121:
---------------------------------------
codecov-commenter commented on pull request #1767:
URL: https://github.com/apache/kylin/pull/1767#issuecomment-966954875
#
[Codecov](https://codecov.io/gh/apache/kylin/pull/1767?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> :exclamation: No coverage uploaded for pull request base (`main@c99b982`).
[Click here to learn what that
means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1767?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1767 +/- ##
=======================================
Coverage ? 24.60%
Complexity ? 4434
=======================================
Files ? 1095
Lines ? 61843
Branches ? 8862
=======================================
Hits ? 15215
Misses ? 45019
Partials ? 1609
```
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/1767?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/1767?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[c99b982...88c854e](https://codecov.io/gh/apache/kylin/pull/1767?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Make JobMetricsUtils.collectMetrics be working again
> ----------------------------------------------------
>
> Key: KYLIN-5121
> URL: https://issues.apache.org/jira/browse/KYLIN-5121
> Project: Kylin
> Issue Type: Improvement
> Reporter: hujiahua
> Priority: Major
>
> At present, the rowCount needs to be eval after the cube built every time,
> and spark `QueryExecution` metric have `numOutputRows` metric for this
> purpose. But, after patch KYLIN-4662 (Migrate from third-party Spark to
> offical Apache Spark), the util function `JobMetricsUtils.collectMetrics`
> becomes out of working. Each rowCount needs to call `Dataset.count()`, which
> wastes resources and affects the cube build time.
> Here is my solution: Get the QueryExecution object based on custom
> QueryExecutionListener, and match the corresponding QueryExecution by
> comparing the output path. (BWT, The output path of cube id is always unique)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
