[
https://issues.apache.org/jira/browse/KYLIN-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17466338#comment-17466338
]
ASF GitHub Bot commented on KYLIN-5097:
---------------------------------------
hit-lacus commented on a change in pull request #1779:
URL: https://github.com/apache/kylin/pull/1779#discussion_r776196021
##########
File path:
source-hive/src/main/java/org/apache/kylin/source/hive/MRHiveDictUtil.java
##########
@@ -114,33 +122,39 @@ public static String generateDropTableStatement(String
tableName) {
}
public static String
generateDistinctValueTableStatement(IJoinedFlatTableDesc flatDesc) {
- StringBuilder ddl = new StringBuilder();
- String table = flatDesc.getTableName()
- +
flatDesc.getSegment().getConfig().getMrHiveDistinctValueTableSuffix();
+ KylinConfig config = flatDesc.getSegment().getConfig();
+ String table = config.getMrHiveDistinctValueTableSuffix();
Review comment:
`table` should be `flatDesc.getTableName() +
config().getMrHiveDistinctValueTableSuffix()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> modify hive dict table format from textfile to orc
> --------------------------------------------------
>
> Key: KYLIN-5097
> URL: https://issues.apache.org/jira/browse/KYLIN-5097
> Project: Kylin
> Issue Type: Bug
> Affects Versions: v3.1.1, v3.1.2, v3.1.3
> Reporter: fengpod
> Priority: Minor
>
> Textfile format end with ‘\n’ by default， when the data itself contains ‘\n’,
> dict table may appear dirty data。
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
