hit-lacus commented on a change in pull request #1809:
URL: https://github.com/apache/kylin/pull/1809#discussion_r801241687
##########
File path: query/src/main/java/org/apache/kylin/query/relnode/OLAPContext.java
##########
@@ -337,7 +340,14 @@ private String
transferDateTimeColumnToMillis(CompareTupleFilter compFilter, Str
}
if (column.getType().isDateTimeFamily()){
- value = String.valueOf(DateFormat.stringToMillis(value));
+ logger.debug("value changed before: {}", value);
+ if(column.getType().isDate()) {
+ // It seems the dynamic parameter has been changed to the date
integer value
+ value = String.valueOf(Long.parseLong(value) * 86400000L);
+ } else {
+ value = String.valueOf(DateFormat.stringToMillis(value));
+ }
+ logger.debug("value changed after: {}", value);
Review comment:
Could you please combine two lines into one line, like : `Column value
changed from {} to {}.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
