[
https://issues.apache.org/jira/browse/KYLIN-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616875#comment-17616875
]
ASF GitHub Bot commented on KYLIN-3561:
---------------------------------------
hit-lacus commented on PR #1995:
URL: https://github.com/apache/kylin/pull/1995#issuecomment-1277245933
Hi, @andreoss , I am glad to see you propose this upgrade, here is my
opinion.
1. For JUnit 5, we already have do it in `kylin5` branch, here is [part of
the
code](https://github.com/apache/kylin/tree/kylin5/src/core-common/src/test/java/org/apache/kylin/junit/annotation).
2. `main` branch is for kylin 4.x, which community may not do much
development work on this branch.
> Upgrade to JUnit 5
> ------------------
>
> Key: KYLIN-3561
> URL: https://issues.apache.org/jira/browse/KYLIN-3561
> Project: Kylin
> Issue Type: Task
> Reporter: Ted Yu
> Priority: Major
> Labels: newbie
> Fix For: Backlog
>
>
> JUnit 5 brings multiple useful features so tests are easier to read and write.
> We can bump up the dependency version and create new tests with JUnit 5
> features.
> Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests
> https://twitter.com/nipafx/status/1027095088059559936
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
