[
https://issues.apache.org/jira/browse/KYLIN-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623592#comment-17623592
]
ASF GitHub Bot commented on KYLIN-5279:
---------------------------------------
hit-lacus commented on PR #2001:
URL: https://github.com/apache/kylin/pull/2001#issuecomment-1290073592
Here is my suggestion.You don't need add a new config entry like:
`kylin.query.asc-order-null-first-enable`.
Looks like you can reuse existent config entry in
`KylinConfigBase#getCalciteExtrasProperties` and remove the overwrite method
`defaultNullCollation` of KECalciteConfig. After that, you
just need set
"kylin.query.calcite.extras-props.defaultNullCollation=low/high/first/last" in
kylin.properties .
> Default null collation for Kylin5.0 sqls should be null-last for ASC order
> and null-first for DESC order.
> ---------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-5279
> URL: https://issues.apache.org/jira/browse/KYLIN-5279
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
> Reporter: Zhenning Zhang
> Assignee: Zhenning Zhang
> Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: image-2022-10-20-15-12-12-967.png
>
>
> according to pgsql:
> [https://www.postgresql.org/docs/current/queries-order.html]
> "By default, null values sort as if larger than any non-null value; that is,
> {{NULLS FIRST}} is the default for {{DESC}} order, and {{NULLS LAST}}
> otherwise."
> currently, the result is:
> !image-2022-10-20-15-12-12-967.png|width=1320,height=743!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
