[
https://issues.apache.org/jira/browse/KYLIN-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627507#comment-17627507
]
ASF GitHub Bot commented on KYLIN-5288:
---------------------------------------
hit-lacus commented on code in PR #2009:
URL: https://github.com/apache/kylin/pull/2009#discussion_r1011319178
##########
kystudio/src/components/common/DataSourceModal/SourceHive/SourceHive.vue:
##########
@@ -2,10 +2,10 @@
<div class="source-hive clearfix" :class="{'zh-lang':
$store.state.system.lang !== 'en'}">
<div class="list clearfix">
<div class="ksd-ml-24 ksd-mt-24">
- <el-input :placeholder="$t('filterTableName')"
Review Comment:
Please don't introduce unnecessary code change.
> suggest set the sampling button default to "off"
> ------------------------------------------------
>
> Key: KYLIN-5288
> URL: https://issues.apache.org/jira/browse/KYLIN-5288
> Project: Kylin
> Issue Type: Improvement
> Components: Client - CLI
> Affects Versions: 5.0-alpha
> Reporter: Li Can
> Priority: Major
> Fix For: 5.0-alpha
>
> Attachments: image-2022-10-31-18-15-04-302.png
>
>
> !image-2022-10-31-18-15-04-302.png|width=380,height=265!
> when the sampling button is on in initial env, if the system db has a mount
> of tables and the user load the whole db, then every table in the db will
> sampling the setting value.it will produce mass data and if the system has no
> enough storage, the system will result in crash。
> So I suggest that when load table from db, the sampling button should be
> 'off' state by default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
