shaofengshi commented on code in PR #2013:
URL: https://github.com/apache/kylin/pull/2013#discussion_r1012449086
##########
core-common/src/main/java/org/apache/kylin/common/util/CliCommandExecutor.java:
##########
@@ -164,7 +164,8 @@ private Pair<Integer, String> runNativeCommand(String
command, Logger logAppende
try {
int exitCode = proc.waitFor();
- return Pair.newPair(exitCode, result.toString());
+ String info = exitCode != 0 ? "Job execute failed, see kylin
log or spark log for more info." : "Success";
+ return Pair.newPair(exitCode, info);
Review Comment:
This changed the behavior, may cause more issues.
Suggestion: how about adding a max. cap to the "result" buffer, so that only
print out the last X characters, say 1K or 10K.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
