[
https://issues.apache.org/jira/browse/KYLIN-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631016#comment-17631016
]
ASF GitHub Bot commented on KYLIN-5246:
---------------------------------------
liuzhao-lz commented on PR #2013:
URL: https://github.com/apache/kylin/pull/2013#issuecomment-1308626865
Hi, I've added unit tests for the RingBuffer.
> long running job's log staying in mem, may cause job server oom
> ---------------------------------------------------------------
>
> Key: KYLIN-5246
> URL: https://issues.apache.org/jira/browse/KYLIN-5246
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
> Affects Versions: v4.0.1
> Reporter: Liu Zhao
> Priority: Minor
>
> {code:java}
> CliCommandExecutor
> --------
> BufferedReader reader = new BufferedReader(
> new InputStreamReader(proc.getInputStream(),
> StandardCharsets.UTF_8));
> String line;
> StringBuilder result = new StringBuilder();
> while ((line = reader.readLine()) != null &&
> !Thread.currentThread().isInterrupted()) {
> result.append(line).append('\n');
> if (logAppender != null) {
> logAppender.log(line);
> }
> }
> {code}
> job运行时间久，result 会非常大，可能会引起内存问题
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
