[
https://issues.apache.org/jira/browse/KYLIN-5291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17634216#comment-17634216
]
ASF GitHub Bot commented on KYLIN-5291:
---------------------------------------
Mukvin commented on code in PR #2015:
URL: https://github.com/apache/kylin/pull/2015#discussion_r1022364553
##########
cache/src/main/java/org/apache/kylin/cache/cachemanager/RemoteLocalFailOverCacheManager.java:
##########
@@ -70,7 +70,7 @@ void enableRemoteCacheManager() {
}
@VisibleForTesting
- MemcachedCacheManager getRemoteCacheManager() {
+ AbstractRemoteCacheManager getRemoteCacheManager() {
return remoteCacheManager;
}
}
Review Comment:
there should be an empty line in the end of file
##########
server/src/main/resources/applicationContext.xml:
##########
@@ -118,6 +118,24 @@
<property name="hosts"
value="${kylin.cache.memcached.hosts}" />
</bean>
-->
+
+ <!
> introducing redis as a distributed cache for kylin
> --------------------------------------------------
>
> Key: KYLIN-5291
> URL: https://issues.apache.org/jira/browse/KYLIN-5291
> Project: Kylin
> Issue Type: New Feature
> Reporter: wuxinqiang
> Priority: Major
> Attachments: KYLIN-5291.main.001.patch, screenshot-1.png,
> screenshot-2.png
>
>
> The distributed cache of kylin4.x only introduces memcache, but currently
> redis is more widely used. If you want to use the distributed cache directly,
> you need to deploy a full set of memcache, and the investment cost is high.
> Memcache has better performance in querying large objects than redis, but
> according to the size distribution of query data currently in Youzan, 99.97%
> of the data is smaller than 1MB, and the scenario is also suitable for
> accessing redis.
> Whether it can introduce Redis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
