hit-lacus commented on PR #2022: URL: https://github.com/apache/kylin/pull/2022#issuecomment-1319477129
This patch looks good to me. Could you please fix the code smell issues? Try to make these issues to zero, if you find some issue are not necessary to fix, you may need this guide (https://9to5answer.com/how-can-we-ignore-some-sonarqube-rules-in-java) .  Thanks, @zznlime , I will merge it after code smell issue are done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
