[jira] [Commented] (KYLIN-5311) Improve performance of getSubstitutor

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/KYLIN-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642264#comment-17642264
 ] 

ASF GitHub Bot commented on KYLIN-5311:
---------------------------------------

sonarcloud[bot] commented on PR #2041:
URL: https://github.com/apache/kylin/pull/2041#issuecomment-1334742067

   SonarCloud Quality Gate failed.    [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2041)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2041&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2041&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2041&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2041&resolved=false&types=CODE_SMELL)
   
   
[![79.6%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'79.6%')](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2041&metric=new_coverage&view=list)
 [79.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2041&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2041&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2041&metric=new_duplicated_lines_density&view=list)
   
   




> Improve performance of getSubstitutor
> -------------------------------------
>
>                 Key: KYLIN-5311
>                 URL: https://issues.apache.org/jira/browse/KYLIN-5311
>             Project: Kylin
>          Issue Type: Bug
>          Components: Others
>            Reporter: Jiale He
>            Priority: Major
>             Fix For: 5.0-alpha
>
>
> h3. Fix Design
> 参考
> +[KYLIN-5274] Improve performance of getSubstitutor - ASF JIRA+
>  # 将substitutor缓存，不重复初始化
>  # 增加{{{}CompositeMapView  {}}} 来同时支持properties和system env
>  # 增加{{{}ICachedExternalConfigLoader{}}} 接口，来标识不可变properties



--
This message was sent by Atlassian Jira
(v8.20.10#820010)