[ 
https://issues.apache.org/jira/browse/KYLIN-5361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656195#comment-17656195
 ] 

ASF GitHub Bot commented on KYLIN-5361:
---------------------------------------

sonarcloud[bot] commented on PR #2068:
URL: https://github.com/apache/kylin/pull/2068#issuecomment-1375959669

   SonarCloud Quality Gate failed.    [![Quality Gate 
failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png
 'Quality Gate 
failed')](https://sonarcloud.io/dashboard?id=apache_kylin&pullRequest=2068)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_kylin&pullRequest=2068&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_kylin&pullRequest=2068&resolved=false&types=CODE_SMELL)
   
   
[![68.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png
 
'68.0%')](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list)
 [68.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_coverage&view=list)
  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_kylin&pullRequest=2068&metric=new_duplicated_lines_density&view=list)
   
   




> suggest set email content from hard code to  configurable  files
> ----------------------------------------------------------------
>
>                 Key: KYLIN-5361
>                 URL: https://issues.apache.org/jira/browse/KYLIN-5361
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Others
>    Affects Versions: 5.0-alpha
>            Reporter: Li Can
>            Assignee: Li Can
>            Priority: Major
>             Fix For: 5.0-alpha
>
>         Attachments: 1672730611150.jpg, 1672730640332.jpg, 1672730668472.jpg, 
> 1672730705781.jpg, 1672730728444.jpg, UI.jpg, emailcontent.png
>
>
> These all email information cannot configure by users with comfortable way, 
> only way just to change the hard code, this method is not suitable for 
> diversity customers.
> So we need adjust the hard code to configurable files, and set relative path 
> to read the file, and then the users can easily modify the contents with the 
> files rather than hard code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to