[
https://issues.apache.org/jira/browse/KYLIN-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17689289#comment-17689289
]
ASF GitHub Bot commented on KYLIN-5387:
---------------------------------------
dethrive commented on code in PR #2089:
URL: https://github.com/apache/kylin/pull/2089#discussion_r1107395563
##########
src/core-metadata/src/main/java/org/apache/kylin/metadata/cube/model/RuleBasedIndex.java:
##########
@@ -348,6 +391,18 @@ Set<LayoutEntity> genCuboidLayouts(Set<LayoutEntity>
previousLayouts, Set<Layout
if (excludeDel) {
genLayouts.removeIf(layout ->
layoutBlackList.contains(layout.getId()));
}
+
+ // If contains the `layout_cost_based_pruned_list`, will use layouts
in the cost based planner list
+ if (useCostBasedList && layoutsOfCostBasedList != null) {
+ // use the recommend white list id
+ Set<LayoutEntity> result = Sets.newHashSet();
+ genLayouts.stream().forEach(layout -> {
Review Comment:
为啥 layoutsOfCostBasedList 这个属性不直接初始化了？
##########
src/core-metadata/src/main/java/org/apache/kylin/metadata/cube/model/RuleBasedIndex.java:
##########
@@ -348,6 +391,18 @@ Set<LayoutEntity> genCuboidLayouts(Set<LayoutEntity>
previousLayouts, Set<Layout
if (excludeDel) {
Review Comment:
这上面生成 layouts 的逻辑需要抽取出来，否则加入了新的逻辑，这边代码复杂度超过了 20
> Migrate cube planner phase 1 to kylin5
> --------------------------------------
>
> Key: KYLIN-5387
> URL: https://issues.apache.org/jira/browse/KYLIN-5387
> Project: Kylin
> Issue Type: Improvement
> Components: Job Engine
> Affects Versions: 5.0-alpha
> Reporter: Kun Liu
> Assignee: Kun Liu
> Priority: Major
>
> kylin3.1 support the cube planner to recommend cuboid when building the first
> segment.
>
> We need to migrate the cost based algorithm to the kylin5, and leverage the
> cube planner algorithm with the index in kylin5
>
> designe doc:
> https://docs.google.com/document/d/1wUNd8U1u-w8T-qQUReplPhDFkETj3AtFr_Shex501ls/edit?usp=sharing
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
