[
https://issues.apache.org/jira/browse/KYLIN-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865756#comment-17865756
] ASF GitHub Bot commented on KYLIN-4780: --------------------------------------- codecov-commenter commented on PR #1596: URL: https://github.com/apache/kylin/pull/1596#issuecomment-2227270754 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1596?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `15.61562%` with `281 lines` in your changes missing coverage. Please review. > Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`kylin3@69368b0`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report. | [Files](https://app.codecov.io/gh/apache/kylin/pull/1596?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/kylin/common/notify/DingTalkService.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FDingTalkService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvRGluZ1RhbGtTZXJ2aWNlLmphdmE=) | 0.00% | [62 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/kylin/common/notify/NotificationContext.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FNotificationContext.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZpY2F0aW9uQ29udGV4dC5qYXZh) | 0.00% | [34 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/kylin/common/notify/NotificationTransmitter.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FNotificationTransmitter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTm90aWZpY2F0aW9uVHJhbnNtaXR0ZXIuamF2YQ==) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rg/apache/kylin/rest/service/MigrationService.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=cube-migration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FMigrationService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3ViZS1taWdyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9NaWdyYXRpb25TZXJ2aWNlLmphdmE=) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/kylin/common/notify/MailService.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2FMailService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvTWFpbFNlcnZpY2UuamF2YQ==) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...ain/java/org/apache/kylin/engine/mr/CubingJob.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FCubingJob.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQ3ViaW5nSm9iLmphdmE=) | 0.00% | [23 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...kylin/common/notify/util/MailNotificationUtil.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2Futil%2FMailNotificationUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvdXRpbC9NYWlsTm90aWZpY2F0aW9uVXRpbC5qYXZh) | 40.54% | [21 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...g/apache/kylin/rest/controller/CubeController.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FCubeController.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9DdWJlQ29udHJvbGxlci5qYXZh) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/kylin/job/execution/AbstractExecutable.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FAbstractExecutable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | 50.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...n/common/notify/util/DingTalkNotificationUtil.java](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fnotify%2Futil%2FDingTalkNotificationUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9ub3RpZnkvdXRpbC9EaW5nVGFsa05vdGlmaWNhdGlvblV0aWwuamF2YQ==) | 64.70% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [9 more](https://app.codecov.io/gh/apache/kylin/pull/1596?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## kylin3 #1596 +/- ## ========================================= Coverage ? 25.32% Complexity ? 6774 ========================================= Files ? 1516 Lines ? 94422 Branches ? 13233 ========================================= Hits ? 23913 Misses ? 68123 Partials ? 2386 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1596?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Refactor AbstractExecutable to extract the notification relevant business > logic into a single component > ------------------------------------------------------------------------------------------------------- > > Key: KYLIN-4780 > URL: https://issues.apache.org/jira/browse/KYLIN-4780 > Project: Kylin > Issue Type: Improvement > Components: Integration > Reporter: vinoyang > Assignee: chenjie > Priority: Major > > Currently, Kylin supports mail service to know the change around the cube. > However, there are some issues about the design, e.g. > * AbstractExecutable contains an implementation of the mechanism of a > notification listener, but only support mail service, it does not belong > there; > * The current implementation is hard to scale to other notification e.g. > Ding Talk(which is a popular production supports by Alibaba) > I propose to refactor the current implementation to extract the notification > logic and redesign a new common notification/listener -- This message was sent by Atlassian Jira (v8.20.10#820010)
