[
https://issues.apache.org/jira/browse/KYLIN-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058598#comment-18058598
]
ASF GitHub Bot commented on KYLIN-4322:
---------------------------------------
codecov-commenter commented on PR #1033:
URL: https://github.com/apache/kylin/pull/1033#issuecomment-3901760972
##
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/1033?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `0%` with `1 line` in your changes missing coverage.
Please review.
:white_check_mark: Project coverage is 25.01%. Comparing base
([`73fc90e`](https://app.codecov.io/gh/apache/kylin/commit/73fc90eea8f9837c8ac680323c0f5e2697fa6c8b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`ccc6d0c`](https://app.codecov.io/gh/apache/kylin/commit/ccc6d0c89e421fb9677e25ea666ecc2b3fd1ece0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/kylin/pull/1033?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://app.codecov.io/gh/apache/kylin/pull/1033?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/kylin/pull/1033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1033 +/- ##
=========================================
Coverage 25.01% 25.01%
Complexity 6180 6180
=========================================
Files 1437 1437
Lines 87620 87624 +4
Branches 12248 12248
=========================================
+ Hits 21917 21921 +4
Misses 63553 63553
Partials 2150 2150
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/kylin/pull/1033?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Cost–benefit of compression HBase result
> ----------------------------------------
>
> Key: KYLIN-4322
> URL: https://issues.apache.org/jira/browse/KYLIN-4322
> Project: Kylin
> Issue Type: Bug
> Reporter: ZhouKang
> Assignee: ZhouKang
> Priority: Major
>
> kylin.storage.hbase.endpoint-compress-result is TRUE as default.
> In our production environment, when the hbase scan result is larger than
> 200M, it will take more than 10s to compress data.
> We can find this by hbase's log:
> ||Size||avg rate||min rate||avg time||max time||
> |<1M|0.12|0.25|0.18ms|0.7s|
> |1M ~ 10M|0.39|0.97|0.2s|0.6s|
> |10M ~ 100M|0.47|0.81|2s|6.3s|
> |>100M|0.95|0.96|15.7s|24.8s|
> Notice：
> # rate: compressed data size / origin data size
> # when the source data size is < 1M, compressed data may larger than the
> source data. So the table(Row 1) only calculate then compressed data less
> than the source data
> # In our environment, 65% compression data (<1M) is larger than source data
> When source data is less then 10M, the latency of data transmission is
> acceptability. When data is larger then 100M, it will take a long time to
> compress data.
>
> So, I think kylin.storage.hbase.endpoint-compress-result should be FALSE by
> default;
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
