[
https://issues.apache.org/jira/browse/KYLIN-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070133#comment-18070133
]
ASF GitHub Bot commented on KYLIN-4039:
---------------------------------------
codecov-commenter commented on PR #730:
URL: https://github.com/apache/kylin/pull/730#issuecomment-4165147115
##
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/730?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `0%` with `26 lines` in your changes missing coverage.
Please review.
:white_check_mark: Project coverage is 25.71%. Comparing base
([`7b1927c`](https://app.codecov.io/gh/apache/kylin/commit/7b1927c709546c8982d234f5ffa1c199fb9d46c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`d311b49`](https://app.codecov.io/gh/apache/kylin/commit/d311b49ae9facc89ff4d7d0aae70b4a4e6624008?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/kylin/pull/730?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...n/job/lock/zookeeper/ZookeeperDistributedLock.java](https://app.codecov.io/gh/apache/kylin/pull/730?src=pr&el=tree&filepath=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Flock%2Fzookeeper%2FZookeeperDistributedLock.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9sb2NrL3pvb2tlZXBlci9ab29rZWVwZXJEaXN0cmlidXRlZExvY2suamF2YQ==)
| 0.00% | [26 Missing :warning:
](https://app.codecov.io/gh/apache/kylin/pull/730?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #730 +/- ##
============================================
- Coverage 25.78% 25.71% -0.08%
+ Complexity 6038 6016 -22
============================================
Files 1392 1386 -6
Lines 82808 82708 -100
Branches 11603 11599 -4
============================================
- Hits 21355 21268 -87
+ Misses 59399 59381 -18
- Partials 2054 2059 +5
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/kylin/pull/730?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> ZookeeperDistributedLock may not release lock when unlock operation was
> interrupted
> -----------------------------------------------------------------------------------
>
> Key: KYLIN-4039
> URL: https://issues.apache.org/jira/browse/KYLIN-4039
> Project: Kylin
> Issue Type: Bug
> Reporter: PENG Zhengshuai
> Assignee: PENG Zhengshuai
> Priority: Major
> Fix For: v3.0.0-beta
>
>
> ZookeeperDistributedLock may hold the lock and not release it when the unlock
> operation was interrupted.
> Because the unlock operation contains two steps:
> 1. peekLock: get the owner of the lock
> 2. purgeLock: purge the lock if the owner of the lock is the current client.
> If the peekLock step is interrupted, the purgeLock step won't be executed.
> Thus the lock won't be released.
> Meanwhile, the lock operation should also consider the interrupt cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
