[
https://issues.apache.org/jira/browse/KYLIN-4879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070583#comment-18070583
]
ASF GitHub Bot commented on KYLIN-4879:
---------------------------------------
codecov-commenter commented on PR #1549:
URL: https://github.com/apache/kylin/pull/1549#issuecomment-4177549583
##
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/1549?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:x: Patch coverage is `78.40909%` with `19 lines` in your changes missing
coverage. Please review.
:white_check_mark: Project coverage is 25.46%. Comparing base
([`5c12d08`](https://app.codecov.io/gh/apache/kylin/commit/5c12d08be9713266ae060796f6e85726cedd6256?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`4483ce8`](https://app.codecov.io/gh/apache/kylin/commit/4483ce8fe2da46fc213edd9a1f2473fe383de6b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing
lines](https://app.codecov.io/gh/apache/kylin/pull/1549?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[.../org/apache/kylin/query/util/SqlCommentParser.java](https://app.codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree&filepath=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FSqlCommentParser.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvU3FsQ29tbWVudFBhcnNlci5qYXZh)
| 78.16% | [6 Missing and 13 partials :warning:
](https://app.codecov.io/gh/apache/kylin/pull/1549?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1549 +/- ##
============================================
+ Coverage 25.43% 25.46% +0.03%
- Complexity 6767 6783 +16
============================================
Files 1508 1509 +1
Lines 93918 94001 +83
Branches 13158 13178 +20
============================================
+ Hits 23890 23940 +50
- Misses 67653 67668 +15
- Partials 2375 2393 +18
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/kylin/pull/1549?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> The function of sql to remove comments is not perfect. In some cases, the sql
> query conditions used will be modified
> --------------------------------------------------------------------------------------------------------------------
>
> Key: KYLIN-4879
> URL: https://issues.apache.org/jira/browse/KYLIN-4879
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: v2.6.0
> Reporter: wangjie
> Assignee: Yaqian Zhang
> Priority: Critical
> Fix For: v3.1.2, v4.0.0
>
>
> In the removeCommentInSql method of QueryUtil of the query module, if the
> single quote character of the user's sql contains – or /**/, the regular
> expression will rewrite the sql query condition.
> E.g:
> (1) When the single quotation mark contains --, line break
> {quote}String sql = "select count(*) from test_kylin_fact WHERE column_name
> ='--this is not comment'\n "+ "LIMIT 100 offset 0";
> {quote}
> After the removeCommentInSql method, it will become:
> {quote}select count(*) from test_kylin_fact WHERE column_name = 'LIMIT 100
> offset 0
> {quote}
> (2) Contain multiple lines of comments in single quotes
> {quote}String sql = "select count(*) from test_kylin_fact WHERE column_name
> ='/**--this *is not comment***/'";
> {quote}
> After the removeCommentInSql method, it will become:
> {quote}select count(*) from test_kylin_fact WHERE column_name =''
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
