[
https://issues.apache.org/jira/browse/KYLIN-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070749#comment-18070749
]
ASF GitHub Bot commented on KYLIN-4399:
---------------------------------------
codecov-commenter commented on PR #1188:
URL: https://github.com/apache/kylin/pull/1188#issuecomment-4181807884
##
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/1188?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 24.97%. Comparing base
([`ebc4c26`](https://app.codecov.io/gh/apache/kylin/commit/ebc4c267b56833475881fb482b1467fbe8367df1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`e937bd3`](https://app.codecov.io/gh/apache/kylin/commit/e937bd3bbdce45abada87525bf470a2b0f9ba6e2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1188 +/- ##
============================================
- Coverage 25.05% 24.97% -0.09%
- Complexity 6248 6339 +91
============================================
Files 1446 1458 +12
Lines 88305 89953 +1648
Branches 12357 12684 +327
============================================
+ Hits 22128 22462 +334
- Misses 64007 65274 +1267
- Partials 2170 2217 +47
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/kylin/pull/1188?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Redirect http url is not override as https when using vip
> ---------------------------------------------------------
>
> Key: KYLIN-4399
> URL: https://issues.apache.org/jira/browse/KYLIN-4399
> Project: Kylin
> Issue Type: Improvement
> Components: Website
> Reporter: Zhong Yanghong
> Assignee: Julian Pan
> Priority: Minor
> Fix For: v3.1.0
>
>
> Redirect http url is not override as https when using vip, when user input:
> https://${vip_name}/kylin/, user will be redirect to sso url do
> authentication, after authenticated, the sso server will redirect url to
> https://${vip_name}/kylin/saml/sso, after process it will redirect to
> http://${vip_name}/kylin/, there should be some redirect override
> configuration in kylinSecurity.xml that can override the location from
> http://${vip_name}:7070/kylin to https://${vip_name}/kylin/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
