[
https://issues.apache.org/jira/browse/KYLIN-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18071236#comment-18071236
] ASF GitHub Bot commented on KYLIN-4348: --------------------------------------- codecov-commenter commented on PR #1096: URL: https://github.com/apache/kylin/pull/1096#issuecomment-4188999511 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1096?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `0.80515%` with `616 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 24.91%. Comparing base ([`33c9f75`](https://app.codecov.io/gh/apache/kylin/commit/33c9f7528e886b1df0ab739648f6ae30bc5c979b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0304549`](https://app.codecov.io/gh/apache/kylin/commit/0304549c6672d800a4a11e8d024695e503dfe211?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1096?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../mr/steps/BuildGlobalHiveDictTotalBuildMapper.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDictTotalBuildMapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljdFRvdGFsQnVpbGRNYXBwZXIuamF2YQ==) | 0.00% | [111 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/kylin/source/hive/CreateMrHiveDictStep.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FCreateMrHiveDictStep.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NyZWF0ZU1ySGl2ZURpY3RTdGVwLmphdmE=) | 0.00% | [95 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...gine/mr/steps/BuildGlobalHiveDictPartBuildJob.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDictPartBuildJob.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljdFBhcnRCdWlsZEpvYi5qYXZh) | 0.00% | [64 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | 0.00% | [60 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...gine/mr/steps/BuildGlobalHiveDicTotalBuildJob.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDicTotalBuildJob.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljVG90YWxCdWlsZEpvYi5qYXZh) | 0.00% | [51 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/mr/steps/BuildGlobalHiveDictPartBuildMapper.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDictPartBuildMapper.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljdFBhcnRCdWlsZE1hcHBlci5qYXZh) | 0.00% | [43 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FMRHiveDictUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL01SSGl2ZURpY3RVdGlsLmphdmE=) | 0.00% | [41 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../org/apache/kylin/engine/mr/JobBuilderSupport.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FJobBuilderSupport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvSm9iQnVpbGRlclN1cHBvcnQuamF2YQ==) | 0.00% | [40 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | 2.85% | [34 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...e/mr/steps/BuildGlobalHiveDicPartBuildReducer.java](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&filepath=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDicPartBuildReducer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljUGFydEJ1aWxkUmVkdWNlci5qYXZh) | 0.00% | [27 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | ... and [6 more](https://app.codecov.io/gh/apache/kylin/pull/1096?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #1096 +/- ## ============================================ - Coverage 25.05% 24.91% -0.15% Complexity 6223 6223 ============================================ Files 1440 1446 +6 Lines 87830 88396 +566 Branches 12275 12341 +66 ============================================ + Hits 22006 22024 +18 - Misses 63666 64212 +546 - Partials 2158 2160 +2 ``` </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kylin/pull/1096?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Fix distributed concurrency lock bug > ------------------------------------ > > Key: KYLIN-4348 > URL: https://issues.apache.org/jira/browse/KYLIN-4348 > Project: Kylin > Issue Type: Sub-task > Reporter: wangxiaojing > Assignee: wangxiaojing > Priority: Major > Fix For: v3.1.0 > > Attachments: image-2020-02-03-10-54-21-976.png, > image-2020-02-03-10-54-53-468.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
