[
https://issues.apache.org/jira/browse/KYLIN-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18140343#comment-18140343
] ASF GitHub Bot commented on KYLIN-4423: --------------------------------------- codecov-commenter commented on PR #1157: URL: https://github.com/apache/kylin/pull/1157#issuecomment-6711113838 ## [Codecov](https://app.codecov.io/gh/apache/kylin/pull/1157?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `28.57143%` with `30 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 25.02%. Comparing base ([`b61d498`](https://app.codecov.io/gh/apache/kylin/commit/b61d4989a842c06f993e9a3df75262c764972589?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`cba5515`](https://app.codecov.io/gh/apache/kylin/commit/cba5515fa9570f22d678a5df9d837b60ccae86a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 329 commits behind head on kylin3. | [Files with missing lines](https://app.codecov.io/gh/apache/kylin/pull/1157?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../apache/kylin/rest/session/KylinSessionConfig.java](https://app.codecov.io/gh/apache/kylin/pull/1157?src=pr&el=tree&filepath=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2Vzc2lvbi9LeWxpblNlc3Npb25Db25maWcuamF2YQ==) | 26.66% | [21 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../apache/kylin/rest/session/KylinSessionFilter.java](https://app.codecov.io/gh/apache/kylin/pull/1157?src=pr&el=tree&filepath=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionFilter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2Vzc2lvbi9LeWxpblNlc3Npb25GaWx0ZXIuamF2YQ==) | 33.33% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/kylin/pull/1157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## kylin3 #1157 +/- ## ============================================ - Coverage 25.06% 25.02% -0.05% - Complexity 6248 6258 +10 ============================================ Files 1446 1451 +5 Lines 88305 88540 +235 Branches 12357 12379 +22 ============================================ + Hits 22131 22154 +23 - Misses 64004 64211 +207 - Partials 2170 2175 +5 ``` </details> [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/kylin/pull/1157?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > use spring session to support clustered sessions > ------------------------------------------------ > > Key: KYLIN-4423 > URL: https://issues.apache.org/jira/browse/KYLIN-4423 > Project: Kylin > Issue Type: New Feature > Reporter: Congling Xia > Assignee: Congling Xia > Priority: Major > > When routing different APIs to different kylin instances, user may encounter > permission problems since there are separate sessions. > To share the sessions, one can config tomcat cluster to replicate all > sessions to all instances. It's a HA solution for Tomcat, and is rarely used > in recent years. Another idea is to store sessions in shared external > storages like Redis. > We choose the latter solution. Spring Session is used to help manage user > sessions and some work has been done to make it pluggable. -- This message was sent by Atlassian Jira (v10.3.26#10030026)
