[ 
https://issues.apache.org/jira/browse/KYLIN-4951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18145888#comment-18145888
 ] 

ASF GitHub Bot commented on KYLIN-4951:
---------------------------------------

codecov-commenter commented on PR #1620:
URL: https://github.com/apache/kylin/pull/1620#issuecomment-6927550315

   ## 
[Codecov](https://app.codecov.io/gh/apache/kylin/pull/1620?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) 
report for BASE (`kylin3@ca08012`). [Learn 
more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit)
 about missing BASE report.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##             kylin3    #1620   +/-   ##
   =========================================
     Coverage          ?   25.34%           
     Complexity        ?     6760           
   =========================================
     Files             ?     1509           
     Lines             ?    94217           
     Branches          ?    13206           
   =========================================
     Hits              ?    23876           
     Misses            ?    67958           
     Partials          ?     2383           
   ```
   </details>
   
   [:umbrella: View full report in Codecov by 
Harness](https://app.codecov.io/gh/apache/kylin/pull/1620?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Change default JVM settings from MaxPermSize to MaxMetaspaceSize
> ----------------------------------------------------------------
>
>                 Key: KYLIN-4951
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4951
>             Project: Kylin
>          Issue Type: Improvement
>            Reporter: Rofi Yao
>            Assignee: Rofi Yao
>            Priority: Major
>             Fix For: Backlog
>
>         Attachments: KYLIN-4951.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> JDK1.8+ is recommended in the Community document.
>  This issue is to switch JVM settings default from MaxPermSize to 
> MaxMetaspaceSize.
>  
> *Problem discovery*
> If you use jdk1.8 and setting MaxPermSize, the query will slow down when 
> non-heap memory is not recovered timely. The threshold value is about 1GB. 
> The average query time may change from 500ms to 1000ms, or more.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to