[
https://issues.apache.org/jira/browse/KYLIN-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18147034#comment-18147034
]
ASF GitHub Bot commented on KYLIN-6124:
---------------------------------------
jlfsdtc opened a new pull request, #2360:
URL: https://github.com/apache/kylin/pull/2360
Project-level pushdown runner and converter classes were checked against
values taken from the system-level configuration. Check the class itself
instead: it must implement IPushDownRunner / IPushDownConverter. The class is
loaded without being initialized.
Add UT for the class check: valid classes for all three keys, blank values,
missing classes, the interfaces themselves, runner and converter mix-ups, and
the pushdown project config endpoint. Pushdown JDBC validation still follows
kylin.source.jdbc.white-list.enabled.
> Potential JDBC validation gap in query pushdown configuration
> -------------------------------------------------------------
>
> Key: KYLIN-6124
> URL: https://issues.apache.org/jira/browse/KYLIN-6124
> Project: Kylin
> Issue Type: Bug
> Affects Versions: 5.0.5
> Reporter: liyang
> Assignee: liyang
> Priority: Major
> Fix For: 5.0.6
>
>
> Project-level query pushdown configuration accepts JDBC URL, driver, and
> runner class values without applying the validation used for source JDBC
> connections. A project administrator can cause pushed-down queries to load a
> chosen JDBC driver and connect to an arbitrary URL.
> Fix direction: apply the existing JDBC URL and driver allowlist to query
> pushdown connection properties, and restrict project-level pushdown runner
> classes to supported implementations.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)