TheSench opened a new pull request #921: SOLR-13816: Move eDisMax params from private interface to public constants URL: https://github.com/apache/lucene-solr/pull/921 # Description `DisMaxParams` contains many eDisMax query string parameters and makes them publicly available so that consuming code does not need to rely on "magic strings". Several of these parameters are missing (but are currently being supplied to the `ExtendedDismaxQParser` by a private interface). # Solution Move the missing parameters from the private static interface `DMP` into the `DixMaxParams` class so that they are publicly accessible to consuming code. # Tests None. This is simply an implementation detail - it is moving the definition of 4 static strings up one layer in a class hierarchy. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `master` branch. - [ ] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
