uwej711 opened a new pull request #930: SOLR-13823: ClassCastException while 
grouping with group.query
URL: https://github.com/apache/lucene-solr/pull/930
 
 
   # Description
   
   When grouping with group.query and returning the score there is a class cast 
exception in Grouping.CommandQuery
   
   # Solution
   
   This PR shows the issue with a failing test. The solution is to use the 
needed collector directly as it is available in CommandQuery and do not cast at 
all. Also you need to populate the scores. I will add another commit with these 
changes.
   
   # Tests
   
   I added a test to TestGroupingSearch.testGroupAPI that groups by query and 
returns the score.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I am authorized to contribute this code to the ASF and have removed 
any code I do not have a license to distribute.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `master` branch.
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [x] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to