chenkovsky edited a comment on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539368862 @janhoy I have fixed the bug. but I cannot pass some test. I think some test cases are inconsistent. in test testBasicKeepOrigTwoOutputs, ``` assertAnalyzesTo(a, "c a b d", new String[] {"c", "x", "m", "a", "y", "n", "o", "b", "d"}, new int[] { 0, 2, 2, 2, 2, 2, 2, 4, 6}, new int[] { 1, 5, 5, 3, 5, 5, 5, 5, 7}, new String[] {"word", "SYNONYM", "SYNONYM", "word", "SYNONYM", "SYNONYM", "SYNONYM", "word", "word"}, new int[] { 1, 1, 0, 0, 1, 1, 1, 1, 1}, new int[] { 1, 1, 2, 4, 4, 1, 2, 1, 1}); ``` the graph looks like ``` c x y _ _ _ d m _ n o a _ _ _ b ``` the tails of synonyms have no overlaps. but in testBasic1, ``` b.add(b, "c d", "dog harness holder extras", true); // .... assertAnalyzesTo(a, "c d c d", new String[] {"dog", "c", "harness", "d", "holder", "extras", "dog", "c", "harness", "d", "holder", "extras"}, new int[] {1, 0, 1, 0, 1, 1, 1, 0, 1, 0, 1, 1}); ``` the graph looks like ``` dog harness holder extras dog harness holder extras c d _ _ c d _ _ ``` the tails of synonyms overlap.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
