mikemccand commented on a change in pull request #913: LUCENE-8995:
TopSuggestDocsCollector#collect should be able to signal rejection
URL: https://github.com/apache/lucene-solr/pull/913#discussion_r334982216
##########
File path: lucene/core/src/java/org/apache/lucene/util/fst/Util.java
##########
@@ -460,11 +460,6 @@ public void addStartPaths(FST.Arc<T> node, T startOutput,
boolean allowEmptyStri
continue;
}
- if (results.size() == topN-1 && maxQueueDepth == topN) {
- // Last path -- don't bother w/ queue anymore:
- queue = null;
Review comment:
Whoa, was this opto breaking something? I guess if this final path is
filtered out, we still need the queue? Have you run the suggest benchmarks to
see if removing this opto hurt performance?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
