HoustonPutman opened a new pull request #991: SOLR-13887: Use default instead of idleTimeouts of 0 for HTTP2 requests URL: https://github.com/apache/lucene-solr/pull/991 # Description In Solr 7, and previous versions, the both the `socketTimeout` and `connTimeout` defaults in `solr.xml` have accepted 0 as values. This is even [documented in the ref guide](https://lucene.apache.org/solr/guide/8_2/format-of-solr-xml.html#defining-solr-xml). Using these same defaults with Solr 8 results in timeouts when trying to manually create replicas. The major change here seems to be that the Http2SolrClient is being used instead of the HttpSolrClient used in Solr 7 and previous versions. After some digging, I think that the issue lies in the Http2SolrClient, specifically in how it enforces idleTimeouts. Since the idleTimeout is set to 0, since that is what solr pulls from the solr.xml, the listener immediately responds with a timeout. # Solution Set a default idleTimeout if 0 is provided. Basically treat an idleTimeout (or socketTimeout) of 0 the same as null. The ref-guide should also likely be updated with the same defaults as used in the solr.xml packaged in Solr. # Tests Added a test to make sure that the use of an idleTimeout of 0 does not immediately timeout requests, and that a default is used. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `master` branch. - [ ] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
