millerjeff0 commented on issue #1009: SOLR-13926
URL: https://github.com/apache/lucene-solr/pull/1009#issuecomment-553645188
 
 
   Yeah I’ll take a shot at method docs next, don’t merge this yet I wanted to 
get the class doc out for review first. 
   
   > On Nov 13, 2019, at 2:56 PM, David Smiley <notificati...@github.com> wrote:
   > 
   > 
   > Cool.
   > 
   > In addition, I find the method contracts to the methods on DocRouter and 
it's subclasses highly unspecified (no javadocs or don't specify this). In 
particular, it's not evident when a id/shardKey/routeKey param is assumed to be 
the prefix, or assumed to be the prefix plus exclamation, or prefix+!+theRest 
or some combinations only or whatever. It makes reasoning about what a method 
should do difficult.
   > 
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to